feat: add mysql engine to cli #228
Conversation
|
Sorry, I missed the PR. Will review soon. |
|
Hi, @xxchan, @BugenZhao. This PR is ready to review. |
sqllogictest-engines/src/mysql.rs
Outdated
| let value_str = match value { | ||
| Value::Bytes(bytes) => match String::from_utf8(bytes) { | ||
| Ok(x) => x, | ||
| Err(_) => "NULL".to_string(), |
There was a problem hiding this comment.
I think this shouldn't be reachable.
sqllogictest-engines/src/mysql.rs
Outdated
| Ok(x) => x, | ||
| Err(_) => "NULL".to_string(), | ||
| }, | ||
| _ => "NULL".to_string(), |
There was a problem hiding this comment.
Can we explicitly assert other variants to be unreachable?
There was a problem hiding this comment.
Yes. The NULL judgment logic has been updated and is now clearer.
sqllogictest-engines/src/mysql.rs
Outdated
| output.push(row_vec); | ||
| } | ||
| if output.is_empty() { | ||
| Ok(DBOutput::StatementComplete(0)) |
There was a problem hiding this comment.
Is there anyway we can retrieve the affected row count?
There was a problem hiding this comment.
Yes, it can be obtained through conn.affected_rows, updated.
Signed-off-by: zjregee <zjregee@gmail.com>
Signed-off-by: zjregee <zjregee@gmail.com>
Signed-off-by: zjregee <zjregee@gmail.com>
Signed-off-by: zjregee <zjregee@gmail.com>
Signed-off-by: zjregee <zjregee@gmail.com>
Signed-off-by: zjregee <zjregee@gmail.com>
Signed-off-by: zjregee <zjregee@gmail.com>
zjregee
force-pushed
the
add-mysql-engine
branch
from
24dac33 to
455286a
Compare
| @@ -44,7 +44,7 @@ You can find more options in `sqllogictest --help` . | |||
|
|
|||
| > **Note** | |||
| > | |||
| > Currently only postgres is supported in the CLI tool. | |||
| > Currently only postgres and mysql are supported in the CLI tool. | |||
There was a problem hiding this comment.
In addition, the description of the cli has been modified here.
Signed-off-by: zjregee <zjregee@gmail.com>
|
It looks like there is an issue with semver ci that is not related to this PR. |
|
published to crates.io and github release |
related: #120